netdev - Re: [PATCH (net-next.git) 01/18] stmmac: share reset function between dwmac100 and dwmac1000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160104.222549.839329360046336198.davem@davemloft.net>
Date:	Mon, 04 Jan 2016 22:25:49 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	peppe.cavallaro@...com
Cc:	netdev@...r.kernel.org, alexandre.torgue@...com
Subject: Re: [PATCH (net-next.git) 01/18] stmmac: share reset function
 between dwmac100 and dwmac1000

From: Giuseppe Cavallaro <peppe.cavallaro@...com>
Date: Mon, 4 Jan 2016 14:06:46 +0100

> @@ -376,7 +376,8 @@ extern const struct stmmac_desc_ops ndesc_ops;
>  /* Specific DMA helpers */
>  struct stmmac_dma_ops {
>  	/* DMA core initialization */
> -	int (*init) (void __iomem *ioaddr, int pbl, int fb, int mb,
> +	int (*reset)(void __iomem *ioaddr);
> +	void (*init)(void __iomem *ioaddr, int pbl, int fb, int mb,
>  		     int burst_len, u32 dma_tx, u32 dma_rx, int atds);

Since you change the return type of the 'init' method, and this
changes the column of the openning parenthesis, you have to fix the
indentation of the argument list on the next line.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html