netdev - Re: [PATCH (net-next.git) 02/18] stmmac: rework DMA bus setting and introduce new platform AXI structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160104.222955.94740482244105696.davem@davemloft.net>
Date:	Mon, 04 Jan 2016 22:29:55 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	peppe.cavallaro@...com
Cc:	netdev@...r.kernel.org, alexandre.torgue@...com
Subject: Re: [PATCH (net-next.git) 02/18] stmmac: rework DMA bus setting
 and introduce new platform AXI structure

From: Giuseppe Cavallaro <peppe.cavallaro@...com>
Date: Mon, 4 Jan 2016 14:06:47 +0100

> @@ -81,7 +81,7 @@ static void stmmac_default_data(struct plat_stmmacenet_data *plat)
>  	plat->mdio_bus_data->phy_mask = 0;
>  
>  	plat->dma_cfg->pbl = 32;
> -	plat->dma_cfg->burst_len = DMA_AXI_BLEN_256;
> +	/* TODO: AXI */
>  
>  	/* Set default value for multicast hash bins */
>  	plat->multicast_filter_bins = HASH_TABLE_SIZE;
> @@ -115,8 +115,8 @@ static int quark_default_data(struct plat_stmmacenet_data *plat,
>  	plat->mdio_bus_data->phy_mask = 0;
>  
>  	plat->dma_cfg->pbl = 16;
> -	plat->dma_cfg->burst_len = DMA_AXI_BLEN_256;
>  	plat->dma_cfg->fixed_burst = 1;
> +	/* AXI (TODO) */
>  
>  	/* Set default value for multicast hash bins */
>  	plat->multicast_filter_bins = HASH_TABLE_SIZE;

Isn't this going to cause a regression for some things?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html