netdev - Re: [PATCH net] net: Propagate lookup failure in l3mdev_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160104.225854.1644508041816573984.davem@davemloft.net>
Date:	Mon, 04 Jan 2016 22:58:54 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	dsa@...ulusnetworks.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] net: Propagate lookup failure in l3mdev_get_saddr
 to caller

From: David Ahern <dsa@...ulusnetworks.com>
Date: Mon,  4 Jan 2016 09:09:27 -0800

> Commands run in a vrf context are not failing as expected on a route lookup:
>     root@...ny:~# ip ro ls table vrf-red
>     unreachable default
> 
>     root@...ny:~# ping -I vrf-red -c1 -w1 10.100.1.254
>     ping: Warning: source address might be selected on device other than vrf-red.
>     PING 10.100.1.254 (10.100.1.254) from 0.0.0.0 vrf-red: 56(84) bytes of data.
> 
>     --- 10.100.1.254 ping statistics ---
>     2 packets transmitted, 0 received, 100% packet loss, time 999ms
> 
> Since the vrf table does not have a route for 10.100.1.254 the ping
> should have failed. The saddr lookup causes a full VRF table lookup.
> Propogating a lookup failure to the user allows the command to fail as
> expected:
> 
>     root@...ny:~# ping -I vrf-red -c1 -w1 10.100.1.254
>     connect: No route to host
> 
> Signed-off-by: David Ahern <dsa@...ulusnetworks.com>

Applied, thanks David.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html