| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20160104.230804.2220774053197810472.davem@davemloft.net> Date: Mon, 04 Jan 2016 23:08:04 -0500 (EST) From: David Miller <davem@...emloft.net> To: eric.dumazet@...il.com Cc: pshelar@...ira.com, netdev@...r.kernel.org, willemdebruijn.kernel@...il.com Subject: Re: [PATCH net v2] skbuff: Fix skb checksum flag on skb pull From: Eric Dumazet <eric.dumazet@...il.com> Date: Wed, 30 Dec 2015 13:05:45 -0500 > On Thu, 2015-09-24 at 14:09 -0700, David Miller wrote: >> From: Pravin B Shelar <pshelar@...ira.com> >> Date: Tue, 22 Sep 2015 12:57:53 -0700 >> >> > VXLAN device can receive skb with checksum partial. But the checksum >> > offset could be in outer header which is pulled on receive. This results >> > in negative checksum offset for the skb. Such skb can cause the assert >> > failure in skb_checksum_help(). Following patch fixes the bug by setting >> > checksum-none while pulling outer header. >> > >> > Following is the kernel panic msg from old kernel hitting the bug. >> ... >> > Reported-by: Anupam Chanda <achanda@...are.com> >> > Signed-off-by: Pravin B Shelar <pshelar@...ira.com> >> >> Applied, thanks. > > > It looks like we also should clear skb->csum ? > > __skb_checksum_complete() definitely would be confused by garbage in > skb->csum Pravin, please take a look at this. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists