netdev - Re: [PATCH for-net V2 00/12] net/mlx5_core: Enhance flow steering support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160110.170524.1947409913228474436.davem@davemloft.net>
Date:	Sun, 10 Jan 2016 17:05:24 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ogerlitz@...lanox.com
Cc:	netdev@...r.kernel.org, dledford@...hat.com, matanb@...lanox.com,
	maorg@...lanox.com, saeedm@...lanox.com, eranbe@...lanox.com
Subject: Re: [PATCH for-net V2 00/12] net/mlx5_core: Enhance flow steering
 support

From: Or Gerlitz <ogerlitz@...lanox.com>
Date: Sun, 10 Jan 2016 10:39:37 +0200

> v1 --> v2 changes:
>   - made sure that service functions added in the IB driver are only static-fied 
>     on the last commit, to make sure bisection with -Werror works fine.

Please don't do this.  This looks rediculous.

Instead, if this kind of dependency exists in a source file, simply
add the new functions in the same commit that adds the usage of
them.