netdev - Re: [PATCH for-net V2 00/12] net/mlx5_core: Enhance flow steering support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ3xEMgxFQszmhWBZmWqfscOBkY8E5JuieXAs86szfeap84EhQ@mail.gmail.com>
Date:	Mon, 11 Jan 2016 06:15:37 +0200
From:	Or Gerlitz <gerlitz.or@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	Or Gerlitz <ogerlitz@...lanox.com>,
	Linux Netdev List <netdev@...r.kernel.org>,
	Doug Ledford <dledford@...hat.com>,
	Matan Barak <matanb@...lanox.com>, maorg@...lanox.com,
	Saeed Mahameed <saeedm@...lanox.com>,
	Eran Ben Elisha <eranbe@...lanox.com>
Subject: Re: [PATCH for-net V2 00/12] net/mlx5_core: Enhance flow steering support

On Mon, Jan 11, 2016 at 12:05 AM, David Miller <davem@...emloft.net> wrote:
> From: Or Gerlitz <ogerlitz@...lanox.com>
> Date: Sun, 10 Jan 2016 10:39:37 +0200
>
>> v1 --> v2 changes:
>>   - made sure that service functions added in the IB driver are only static-fied
>>     on the last commit, to make sure bisection with -Werror works fine.
>
> Please don't do this.  This looks rediculous.

> Instead, if this kind of dependency exists in a source file, simply
> add the new functions in the same commit that adds the usage of
> them.

OKay, we did that to get better breakup of the patches to smaller
units, will squash the last two patches and respin

Or.