netdev - Re: [PATCH v2] netlink: fix null pointer dereference on nlk->groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160110.232707.1954364745984617361.davem@davemloft.net>
Date:	Sun, 10 Jan 2016 23:27:07 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sploving1@...il.com
Cc:	sergei.shtylyov@...entembedded.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2] netlink: fix null pointer dereference on nlk->groups

From: Baozeng Ding <sploving1@...il.com>
Date: Sat,  9 Jan 2016 23:56:41 +0800

> If groups is not 0 and nlk->groups is NULL, it will not return
> immediately and cause a null pointer dereference later.
> 
> Signed-off-by: Baozeng Ding <sploving1@...il.com>
> ---
> This version uses the preferred networking coding style. Thanks
> for Sergei's feedback. Also the patch keeps the original author's
> coding style as much as possible.

Is this an actual legal state?  If not, add a WARN_ON() check.

Otherwise, provide a proper OOPS log and explain how the state
can be achieved.

Thanks.