netdev - Re: [PATCH 13/53] perf tools: Prevent calling machine_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5694A54B.3090209@huawei.com>
Date:	Tue, 12 Jan 2016 15:03:39 +0800
From:	"Wangnan (F)" <wangnan0@...wei.com>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
CC:	<linux-kernel@...r.kernel.org>, <pi3orama@....com>,
	<lizefan@...wei.com>, <netdev@...r.kernel.org>,
	<davem@...emloft.net>, Jiri Olsa <jolsa@...nel.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH 13/53] perf tools: Prevent calling machine__delete() on
 non-allocated machine



On 2016/1/11 23:42, Arnaldo Carvalho de Melo wrote:
> Em Mon, Jan 11, 2016 at 01:48:04PM +0000, Wang Nan escreveu:
>> To prevent futher commits calling machine__delete() on non-allocated
>> 'struct machine' (which would cause memory corruption), this patch
>> enforces machine__init(), record whether a machine structure is
>> dynamically allocated or not, and warn if machine__delete() is called
>> on incorrect object.
> Not sure on this one, I think I voiced this before, this seems like
> something to be tested using some static analysis tool or even checking
> if the address for the struct hitting machine__delete() is from malloc
> or not.
>
> I.e. if we do it here, we may have to do it to any other struct where we
> allocate it in the stack or via malloc, and furthermore there are cases
> where we embed a struct in another, when we would free just the main
> struct but not the second, embedded one, that would need just calling
> foo__exit() and not foo__delete().
>
> - Arnaldo
>   
OK. Let's drop this one.

Thank you.