netdev - Re: [PATCH] net: phy: turn carrier off on phy attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160115.145003.183831730517733849.davem@davemloft.net>
Date:	Fri, 15 Jan 2016 14:50:03 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sjoerd.simons@...labora.co.uk
Cc:	netdev@...r.kernel.org, andrew@...n.ch,
	linux-kernel@...r.kernel.org, f.fainelli@...il.com
Subject: Re: [PATCH] net: phy: turn carrier off on phy attach

From: Sjoerd Simons <sjoerd.simons@...labora.co.uk>
Date: Thu, 14 Jan 2016 21:57:18 +0100

> The operstate of a networking device initially IF_OPER_UNKNOWN aka
> "unknown", updated on carrier state changes (with carrier state being on
> by default). This means it will stay unknown unless the carrier state
> goes to off at some point, which is not the case if the phy is already
> up/connected at startup.
> 
> Explicitly turn off the carrier on phy attach, leaving the phy state
> machine to turn the carrier on when it has done the initial negotiation.
> 
> Signed-off-by: Sjoerd Simons <sjoerd.simons@...labora.co.uk>

Applied, thank you.