netdev - Re: [PATCH] net: phy: smsc: Fix disabling energy detect mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160115.145502.1019508793273660216.davem@davemloft.net>
Date:	Fri, 15 Jan 2016 14:55:02 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	t.remmet@...tec.de
Cc:	netdev@...r.kernel.org, f.fainelli@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: phy: smsc: Fix disabling energy detect mode

From: Teresa Remmet <t.remmet@...tec.de>
Date: Fri, 15 Jan 2016 10:20:33 +0100

> @@ -110,10 +105,11 @@ static int lan911x_config_init(struct phy_device *phydev)
>   */
>  static int lan87xx_read_status(struct phy_device *phydev)
>  {
> +	bool *energy_enable = phydev->priv;
>  	int err = genphy_read_status(phydev);
>  	int i;

Please order local variable declarations from longest to shortest line.

> +static int smsc_phy_probe(struct phy_device *phydev)
> +{
> +	struct device *dev = &phydev->mdio.dev;
> +	bool *energy_enable;
> +	int __maybe_unused len;
> +	struct device_node *of_node __maybe_unused = dev->of_node;

Likewise.