netdev - Re: [PATCH net v4] ovs: limit ovs recursions in ovs_execute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160118.115030.221096335100780663.davem@davemloft.net>
Date:	Mon, 18 Jan 2016 11:50:30 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	hannes@...essinduktion.org
Cc:	pshelar@....org, netdev@...r.kernel.org,
	simon.horman@...ronome.com, eric.dumazet@...il.com
Subject: Re: [PATCH net v4] ovs: limit ovs recursions in
 ovs_execute_actions to not corrupt stack

From: Hannes Frederic Sowa <hannes@...essinduktion.org>
Date: Mon, 18 Jan 2016 12:21:16 +0100

> I don't think that -rt kernels are important for openvswitch right
> now, so this is just a safe guard.

Hannes, whilst I don't want to explicitly make things harder for the -rt
folks, I don't think it's appropriate to put unnecessary preemtption
disables into the main kernel like this.

Someone reading the code as-is will say this is superfluous and (correctly)
submit a patch to remove the preemption disables.

Please remove this from your patch, someone can deal with this in the
-rt kernel as needed.