netdev - Re: [PATCH net v4] ovs: limit ovs recursions in ovs_execute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <569D19B4.5010707@stressinduktion.org>
Date:	Mon, 18 Jan 2016 17:58:28 +0100
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	David Miller <davem@...emloft.net>
Cc:	pshelar@....org, netdev@...r.kernel.org,
	simon.horman@...ronome.com, eric.dumazet@...il.com
Subject: Re: [PATCH net v4] ovs: limit ovs recursions in ovs_execute_actions
 to not corrupt stack

On 18.01.2016 17:50, David Miller wrote:
> From: Hannes Frederic Sowa <hannes@...essinduktion.org>
> Date: Mon, 18 Jan 2016 12:21:16 +0100
>
>> I don't think that -rt kernels are important for openvswitch right
>> now, so this is just a safe guard.
>
> Hannes, whilst I don't want to explicitly make things harder for the -rt
> folks, I don't think it's appropriate to put unnecessary preemtption
> disables into the main kernel like this.
>
> Someone reading the code as-is will say this is superfluous and (correctly)
> submit a patch to remove the preemption disables.
>
> Please remove this from your patch, someone can deal with this in the
> -rt kernel as needed.

I am fine with that. Actually I had the same feeling, but seeing such a 
patch being discussed and explicitly ignoring this issue in another part 
made me feel a little bit bad.

Will resend in some seconds.

Bye,
Hannes