netdev - RE: [PATCH net] lan78xx: changed to use updated phy-ignore-interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9235D6609DB808459E95D78E17F2E43D4049DBE4@CHN-SV-EXMX02.mchp-main.com>
Date:	Mon, 25 Jan 2016 16:26:09 +0000
From:	<Woojung.Huh@...rochip.com>
To:	<f.fainelli@...il.com>, <davem@...emloft.net>
CC:	<netdev@...r.kernel.org>
Subject: RE: [PATCH net] lan78xx: changed to use updated
 phy-ignore-interrupts

Florian,

> Looks fine, just one nit below:
> 
> > @@ -954,6 +956,7 @@ static int lan78xx_link_reset(struct lan78xx_net
> *dev)
> >
> >  		ret = lan78xx_update_flowcontrol(dev, ecmd.duplex, ladv,
> radv);
> >  		netif_carrier_on(dev->net);
> 
> Do you need this netif_carrier_on() call here? PHYLIB should set that
> already.
> 
> > +		phy_mac_interrupt(phydev, 1);
> >  	}

Thanks for feedback.
As you pointed, netif_carrier_on() is redundant and also netif_carrier_off() in same routine.
Will post new patch.

Thanks,
Woojung