netdev - Re: [PATCH net 1/3] sctp: fix the transport dead race check by using atomic_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160125.104446.2231255639148070984.davem@davemloft.net>
Date:	Mon, 25 Jan 2016 10:44:46 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	vyasevich@...il.com
Cc:	marcelo.leitner@...il.com, lucien.xin@...il.com,
	netdev@...r.kernel.org, linux-sctp@...r.kernel.org,
	daniel@...earbox.net
Subject: Re: [PATCH net 1/3] sctp: fix the transport dead race check by
 using atomic_add_unless on refcnt

From: Vlad Yasevich <vyasevich@...il.com>
Date: Fri, 22 Jan 2016 13:54:09 -0500

> OK,  I see how that holds together, but I think there might be hole wrt icmp
> handling.  Some icmp processes assume transport can't disappear on them, but in
> this case that last put(transport) may result in a call to sctp_transport_destroy()
> and that might be bad.  I am looking at it now.

Vlad, this patch series is being held up because of this.  Please resolve
this one way or the other at your earliest possible convenience, thanks.