lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAGRGNgV7MUXdk+e8Arx05yiWX6owei5dmnFQ-TBfs55jfy+qBw@mail.gmail.com> Date: Wed, 27 Jan 2016 09:55:55 +1100 From: Julian Calaby <julian.calaby@...il.com> To: Cong Wang <xiyou.wangcong@...il.com> Cc: netdev <netdev@...r.kernel.org>, dvyukov@...gle.com, linux-wireless <linux-wireless@...r.kernel.org>, Lauro Ramos Venancio <lauro.venancio@...nbossa.org>, Aloisio Almeida Jr <aloisio.almeida@...nbossa.org>, Samuel Ortiz <sameo@...ux.intel.com> Subject: Re: [PATCH RESEND net] nfc: use GFP_USER for user-controlled kmalloc Hi Cong, On Wed, Jan 27, 2016 at 4:53 AM, Cong Wang <xiyou.wangcong@...il.com> wrote: A commit message would be nice. A brief rundown of how this is called from userspace would be nice (I'm talking a single sentence here, e.g. "this is allocated when submitting a nfc packet") and what issue __GFP_NOWARN is fixing. (I'm guessing log spam due to allocation failures.) > Reported-by: Dmitry Vyukov <dvyukov@...gle.com> > Cc: Lauro Ramos Venancio <lauro.venancio@...nbossa.org> > Cc: Aloisio Almeida Jr <aloisio.almeida@...nbossa.org> > Cc: Samuel Ortiz <sameo@...ux.intel.com> > Signed-off-by: Cong Wang <xiyou.wangcong@...il.com> > --- > net/nfc/llcp_commands.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/nfc/llcp_commands.c b/net/nfc/llcp_commands.c > index 3621a90..5d94055 100644 > --- a/net/nfc/llcp_commands.c > +++ b/net/nfc/llcp_commands.c > @@ -729,7 +729,7 @@ int nfc_llcp_send_ui_frame(struct nfc_llcp_sock *sock, u8 ssap, u8 dsap, > if (local == NULL) > return -ENODEV; > > - msg_data = kzalloc(len, GFP_KERNEL); > + msg_data = kzalloc(len, GFP_USER | __GFP_NOWARN); > if (msg_data == NULL) > return -ENOMEM; Thanks, -- Julian Calaby Email: julian.calaby@...il.com Profile: http://www.google.com/profiles/julian.calaby/
Powered by blists - more mailing lists