[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20160128.160206.1148428775767129968.davem@davemloft.net>
Date: Thu, 28 Jan 2016 16:02:06 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: joe@....org
Cc: netdev@...r.kernel.org, fw@...len.de, hannes@...essinduktion.org,
pshelar@....org
Subject: Re: [PATCH net] inet: frag: Always orphan skbs inside ip_defrag()
From: Joe Stringer <joe@....org>
Date: Fri, 22 Jan 2016 15:49:12 -0800
> Later parts of the stack (including fragmentation) expect that there is
> never a socket attached to frag in a frag_list, however this invariant
> was not enforced on all defrag paths. This could lead to the
> BUG_ON(skb->sk) during ip_do_fragment(), as per the call stack at the
> end of this commit message.
>
> While the call could be added to openvswitch to fix this particular
> error, the head and tail of the frags list are already orphaned
> indirectly inside ip_defrag(), so it seems like the remaining fragments
> should all be orphaned in all circumstances.
...
> Fixes: 7f8a436eaa2c ("openvswitch: Add conntrack action")
> Signed-off-by: Joe Stringer <joe@....org>
Applied and queued up for -stable, thanks Joe.
Powered by blists - more mailing lists