netdev - Re: [PATCH] net_sched: drr: check for NULL pointer in drr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXVx6xEs==KyiD4-rQu6-Kiu2Q7jC-zPSKXaU4w6CJzqA@mail.gmail.com>
Date:	Fri, 29 Jan 2016 10:19:16 -0800
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Bernie Harris <bernie.harris@...iedtelesis.co.nz>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Jamal Hadi Salim <jhs@...atatu.com>, stable@...r.kernel.org
Subject: Re: [PATCH] net_sched: drr: check for NULL pointer in drr_dequeue

On Wed, Jan 27, 2016 at 7:30 PM, Bernie Harris
<bernie.harris@...iedtelesis.co.nz> wrote:
> There are cases where qdisc_dequeue_peeked can return NULL, and the result
> is dereferenced later on in the function.
>
> Similarly to the other qdisc dequeue functions, check whether the skb
> pointer is NULL and if it is, goto out.
>
> Signed-off-by: Bernie Harris <bernie.harris@...iedtelesis.co.nz>

Reviewed-by: Cong Wang <xiyou.wangcong@...il.com>