netdev - Re: [PATCH net v2 1/4] net/core: relax BUILD_BUG_ON in netdev_stats_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160130.152635.1510710440132684620.davem@davemloft.net>
Date:	Sat, 30 Jan 2016 15:26:35 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jarod@...hat.com
Cc:	eric.dumazet@...il.com, linux-kernel@...r.kernel.org,
	edumazet@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH net v2 1/4] net/core: relax BUILD_BUG_ON in
 netdev_stats_to_stats64

From: Jarod Wilson <jarod@...hat.com>
Date: Sat, 30 Jan 2016 15:53:05 -0500

> On Sat, Jan 30, 2016 at 03:39:01PM -0500, Jarod Wilson wrote:
>> Ew, no, it won't work correctly on 32-bit. The for loop is going to copy
>> data into dst from beyond the end of netdev_stats, and the range looks
>> like it won't be right either, only half of the added stats64 space will
>> get zeroed out. Okay, I'll fix that up correctly.
> 
> Completely untested as of yet, but I think something like the following
> looks correct. I'll give it a spin as soon as I can.

Jarod, please respin your entire series as a v3 once you sort this out.

Thanks.