lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20160131180704.GA36726@redhat.com> Date: Sun, 31 Jan 2016 13:07:04 -0500 From: Jarod Wilson <jarod@...hat.com> To: David Miller <davem@...emloft.net> Cc: eric.dumazet@...il.com, linux-kernel@...r.kernel.org, edumazet@...gle.com, netdev@...r.kernel.org Subject: Re: [PATCH net v2 1/4] net/core: relax BUILD_BUG_ON in netdev_stats_to_stats64 On Sat, Jan 30, 2016 at 03:26:35PM -0800, David Miller wrote: > From: Jarod Wilson <jarod@...hat.com> > Date: Sat, 30 Jan 2016 15:53:05 -0500 > > > On Sat, Jan 30, 2016 at 03:39:01PM -0500, Jarod Wilson wrote: > >> Ew, no, it won't work correctly on 32-bit. The for loop is going to copy > >> data into dst from beyond the end of netdev_stats, and the range looks > >> like it won't be right either, only half of the added stats64 space will > >> get zeroed out. Okay, I'll fix that up correctly. > > > > Completely untested as of yet, but I think something like the following > > looks correct. I'll give it a spin as soon as I can. > > Jarod, please respin your entire series as a v3 once you sort this out. Will do. I should be able to get it tested out on a 32-bit setup Monday. -- Jarod Wilson jarod@...hat.com
Powered by blists - more mailing lists