lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 3 Feb 2016 22:50:25 +0200 From: Aaro Koskinen <aaro.koskinen@....fi> To: Andrew Lunn <andrew@...n.ch> Cc: David Miller <davem@...emloft.net>, netdev@...r.kernel.org, Florian Fainelli <f.fainelli@...il.com>, David Daney <ddaney@...iumnetworks.com> Subject: Re: [PATCH] of: of_mdio: Add marvell,88e1145 to whitelist of PHY compatibilities. Hi, On Wed, Feb 03, 2016 at 09:08:57PM +0100, Andrew Lunn wrote: > On Wed, Feb 03, 2016 at 09:35:29PM +0200, Aaro Koskinen wrote: > > Commit ae461131960b ("of: of_mdio: Add a whitelist of PHY > > compatibilities.") missed one compatible string used in in-tree DTBs: > > in OCTEON, for selected boards, the kernel DTB pruning code will overwrite > > the DTB compatible string with "marvell,88e1145", which is missing > > from the whitelist. Add it. > > Does this overwriting means this compatibility is not visible in the > current DTS files? Or did i miss it? Yeah, it happens in arch/mips/cavium-octeon/octeon-platform.c: if (octeon_has_88e1145()) { fdt_nop_property(initial_boot_params, phy, "marvell,reg-init"); memset(new_name, 0, sizeof(new_name)); strcpy(new_name, "marvell,88e1145"); It took a while for me to figure out this as well... Nasty. > At least for the Marvell SoCs i intend to submit a patch removing > these compatible strings from the DTS files. Will you do the same for > the OCTEON boards? Yes, for in-tree OCTEON DTS files, I can do the update; the above strcpy needs to be deleted at the same go, and this needs go through MIPS tree. A.
Powered by blists - more mailing lists