lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 3 Feb 2016 22:02:05 +0100 From: "Jason A. Donenfeld" <Jason@...c4.com> To: Julian Anastasov <ja@....bg> Cc: Netdev <netdev@...r.kernel.org>, David Miller <davem@...emloft.net>, "Eric W. Biederman" <ebiederm@...ssion.com>, David Ahern <dsa@...ulusnetworks.com> Subject: Re: [PATCH] flowi: add concept of "not_oif" Hi Julian, Thanks a lot for your review. Much appreciated. On Wed, Feb 3, 2016 at 9:42 PM, Julian Anastasov <ja@....bg> wrote: > If you check every flowi4_oif user you will notice > that some places can not fulfil this requirement: > - fib_select_path -> fib_select_multipath > Other places like fib_select_default are called > for flowi4_oif=0 and there are no other checks for flowi4_oif > but they will be needed for the new field. > fans, you have to check all places that use flowi4_oif and > flowi6_oif. > missing initialization of this new field Thanks for pointing these out. I will take this into account and send an updated patch [series]. > I don't know about the particular problems with > tunnels but the scripts can use the route metric to order > the routes in a table. This unfortunately does not cut it with tunnels. Jason
Powered by blists - more mailing lists