netdev - Re: [PATCH net-next v5 1/2] ethtool: add speed/duplex validation functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 4 Feb 2016 10:32:26 +1100
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Nikolay Aleksandrov <razor@...ckwall.org>
Cc:	netdev@...r.kernel.org, mst@...hat.com, roopa@...ulusnetworks.com,
	davem@...emloft.net,
	Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Subject: Re: [PATCH net-next v5 1/2] ethtool: add speed/duplex validation
 functions

On Wed,  3 Feb 2016 04:04:36 +0100
Nikolay Aleksandrov <razor@...ckwall.org> wrote:

>  
> +static inline int ethtool_validate_speed(__u32 speed)
> +{

No need for inline.

But why check for valid value at all. At some point in the
future, there will be yet another speed adopted by some standard body
and the switch statement would need another value.

Why not accept any value? This is a virtual device.