lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 3 Feb 2016 15:49:04 -0800 From: Rick Jones <rick.jones2@....com> To: Stephen Hemminger <stephen@...workplumber.org>, Nikolay Aleksandrov <razor@...ckwall.org> Cc: netdev@...r.kernel.org, mst@...hat.com, roopa@...ulusnetworks.com, davem@...emloft.net, Nikolay Aleksandrov <nikolay@...ulusnetworks.com> Subject: Re: [PATCH net-next v5 1/2] ethtool: add speed/duplex validation functions On 02/03/2016 03:32 PM, Stephen Hemminger wrote: > But why check for valid value at all. At some point in the > future, there will be yet another speed adopted by some standard body > and the switch statement would need another value. > > Why not accept any value? This is a virtual device. > And even for not-quite-virtual devices - such as a VC/FlexNIC in an HPE blade server there can be just about any speed set. I think we went down a path of patching some things to address that many years ago. It would be a shame to undo that. rick
Powered by blists - more mailing lists