lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 3 Feb 2016 01:57:11 +0100
From:	Hannes Frederic Sowa <>
To:	Linus Torvalds <>
Cc:	Network Development <>,
	Tetsuo Handa <>,
	Simon McVittie <>,
	Willy Tarreau <>, Eric Dumazet <>,
	linux-kernel <>,
	"David S. Miller" <>,
	???????? ?????????????????? <>,
	David Herrmann <>
Subject: Re: [PATCH v2] unix: properly account for FDs passed over unix

On 02.02.2016 23:11, Linus Torvalds wrote:
> [ sorry for the html mail, I'm out grocery shopping ]
> On Feb 2, 2016 13:55, "Hannes Frederic Sowa" <>
> wrote:
>> I slightly tested the attached patch.
> Looks fine. I do wonder: if the only thing we use that "struct cred" for is
> to do that ->user lookup, maybe we should just use "struct user_struct"
> directly, and skip the cred entirely.
> Something like
>      fp->user = get_uid(current_user());
> and then
>      put_uid(fp->user);
> But I'm OK with that patch as is if you prefer it that way (maybe you want
> to use the cred to then test for root separately etc, out maybe there
> already was done use of cred as cred that I just missed when reading the
> patch on my phone..)

I don't see any reason to switch over to struct user_struct. I tested a 
patch and will send it out soon.


Powered by blists - more mailing lists