netdev - RE: [PATCH net-next] Add LAN9352 Ethernet Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <90A7E81AE28BAE4CBDDB3B35F187D264402EF2F0@CHN-SV-EXMX02.mchp-main.com>
Date:	Wed, 10 Feb 2016 18:26:01 +0000
From:	<Bryan.Whitehead@...rochip.com>
To:	<davem@...emloft.net>
CC:	<netdev@...r.kernel.org>, <corbet@....net>
Subject: RE: [PATCH net-next] Add LAN9352 Ethernet Driver

Thanks David,

I'll submit a revised patch soon.

-----Original Message-----
From: David Miller [mailto:davem@...emloft.net] 
Sent: Wednesday, February 10, 2016 5:34 AM
To: Bryan Whitehead - C21958
Cc: netdev@...r.kernel.org; corbet@....net
Subject: Re: [PATCH net-next] Add LAN9352 Ethernet Driver

From: <Bryan.Whitehead@...rochip.com>
Date: Tue, 9 Feb 2016 20:40:30 +0000

> +#ifdef USE_PHY_WORK_AROUND
> +#define MIN_PACKET_SIZE (64)
> +	char loopback_tx_pkt[MIN_PACKET_SIZE];
> +	char loopback_rx_pkt[MIN_PACKET_SIZE];
> +	unsigned int resetcount;
> +#endif
 ...
> +#define USE_PHY_WORK_AROUND

If you're going to unconditionally define this, and not provide a Kconfig mechanism to change it, just get rid of this and the CPP tests upon it.

Thanks.