netdev - Re: [PATCH net-next 1/3] lan78xx: replace devid to chipid & chiprev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160210224558.GB14610@lunn.ch>
Date:	Wed, 10 Feb 2016 23:45:58 +0100
From:	Andrew Lunn <andrew@...n.ch>
To:	Woojung.Huh@...rochip.com
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/3] lan78xx: replace devid to chipid & chiprev

On Wed, Feb 10, 2016 at 09:13:37PM +0000, Woojung.Huh@...rochip.com wrote:
> 
> Replace devid to chipid & chiprev for easy access.
> 
> Signed-off-by: Woojung Huh <woojung.huh@...rochip.com>
> ---
>  drivers/net/usb/lan78xx.c | 20 +++++++++++---------
>  drivers/net/usb/lan78xx.h |  1 +
>  2 files changed, 12 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
> index 1c299b8..b14b22d 100644
> --- a/drivers/net/usb/lan78xx.c
> +++ b/drivers/net/usb/lan78xx.c
> @@ -278,7 +278,8 @@ struct lan78xx_net {
>  	int			link_on;
>  	u8			mdix_ctrl;
>  
> -	u32			devid;
> +	u32			chipid;
> +	u32			chiprev;
>  	struct mii_bus		*mdiobus;
>  };
>  
> @@ -471,7 +472,7 @@ static int lan78xx_read_raw_eeprom(struct lan78xx_net *dev, u32 offset,
>  	 */
>  	ret = lan78xx_read_reg(dev, HW_CFG, &val);
>  	saved = val;
> -	if ((dev->devid & ID_REV_CHIP_ID_MASK_) == 0x78000000) {
> +	if ((dev->chipid) == ID_REV_CHIP_ID_7800_) {

Why the extra ( ... )?

    Andrew