netdev - RE: [PATCH net-next 1/3] lan78xx: replace devid to chipid & chiprev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9235D6609DB808459E95D78E17F2E43D404ABB1E@CHN-SV-EXMX02.mchp-main.com>
Date:	Wed, 10 Feb 2016 22:49:10 +0000
From:	<Woojung.Huh@...rochip.com>
To:	<sergei.shtylyov@...entembedded.com>, <andrew@...n.ch>
CC:	<netdev@...r.kernel.org>, <davem@...emloft.net>
Subject: RE: [PATCH net-next 1/3] lan78xx: replace devid to chipid & chiprev

Thanks Sergei & Andrew,
Will remove extra brackets and repost.

Woojung 

> > @@ -471,7 +472,7 @@ static int lan78xx_read_raw_eeprom(struct
> lan78xx_net *dev, u32 offset,
> >   	 */
> >   	ret = lan78xx_read_reg(dev, HW_CFG, &val);
> >   	saved = val;
> > -	if ((dev->devid & ID_REV_CHIP_ID_MASK_) == 0x78000000) {
> > +	if ((dev->chipid) == ID_REV_CHIP_ID_7800_) {


> > @@ -505,7 +506,7 @@ static int lan78xx_read_raw_eeprom(struct
> lan78xx_net *dev, u32 offset,
> >
> >   	retval = 0;
> >   exit:
> > -	if ((dev->devid & ID_REV_CHIP_ID_MASK_) == 0x78000000)
> > +	if ((dev->chipid) == ID_REV_CHIP_ID_7800_)


> > @@ -539,7 +540,7 @@ static int lan78xx_write_raw_eeprom(struct
> lan78xx_net *dev, u32 offset,
> >   	 */
> >   	ret = lan78xx_read_reg(dev, HW_CFG, &val);
> >   	saved = val;
> > -	if ((dev->devid & ID_REV_CHIP_ID_MASK_) == 0x78000000) {
> > +	if ((dev->chipid) == ID_REV_CHIP_ID_7800_) {


> > @@ -587,7 +588,7 @@ static int lan78xx_write_raw_eeprom(struct
> lan78xx_net *dev, u32 offset,
> >
> >   	retval = 0;
> >   exit:
> > -	if ((dev->devid & ID_REV_CHIP_ID_MASK_) == 0x78000000)
> > +	if ((dev->chipid) == ID_REV_CHIP_ID_7800_)