netdev - Re: [PATCH v2] net: fec: Add "phy-reset-active-low" property to DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqJX+MuN3LXW-bSTo1cj2JM0h_dw3JYx6jF7EUZVgDf=gQ@mail.gmail.com>
Date:	Fri, 12 Feb 2016 13:44:28 -0600
From:	Rob Herring <robh@...nel.org>
To:	Fabio Estevam <festevam@...il.com>
Cc:	Bernhard Walle <bernhard@...lle.de>,
	Fabio Estevam <fabio.estevam@...escale.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v2] net: fec: Add "phy-reset-active-low" property to DT

On Fri, Feb 12, 2016 at 9:24 AM, Fabio Estevam <festevam@...il.com> wrote:
> On Fri, Feb 12, 2016 at 1:20 PM, Rob Herring <robh@...nel.org> wrote:
>
>> This is what the gpio flags are for. Why can't you use that?
>
> This has already been discussed in v1:
> https://lkml.org/lkml/2016/2/8/867

Thanks. That's fine, but that detail should be explained in the
binding. Is there a specific compatible string this can be limited to?
It should also be stated that the GPIO flags should be correct rather
than ignored implying I can put in whatever I want there. Then someday
if no more wrong dtbs are in the wild, it can switch back to using
gpio flags. Also, phy-reset-active-low should be prefixed with "fsl,".

Rob