netdev - Re: [PATCH net-next,V2] Add LAN9352 Ethernet Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160216.154358.164326104187806534.davem@davemloft.net>
Date:	Tue, 16 Feb 2016 15:43:58 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	andrew@...n.ch
Cc:	Bryan.Whitehead@...rochip.com, f.fainelli@...il.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next,V2] Add LAN9352 Ethernet Driver

From: Andrew Lunn <andrew@...n.ch>
Date: Tue, 16 Feb 2016 21:36:25 +0100

> So this is the discussion we need to have.
> 
> The interface to the outside work is the two switch ports with real
> PHYs. What you are implementing is an Ethernet driver for an internal
> port connected to the switch. This port does not go to the outside
> world. This driver provides no way to control the ports to the outside
> world and you have no short term plan to actually implement control of
> the ports connected to the outside world.
> 
> Should the Linux community accept this driver in this state?
> 
> I would prefer to see a simple switchdev or DSA driver which exposes
> the two external ports.

I do not think, with all the infrastructure we have, that we should accept
pure ethernet drivers for such devices any more.

About year ago I would have responded differently, but these days all of
the necessary support and infrastructure is there, and reasonable easy
for driver authors to use.