netdev - Re: [net-next] net: l3mdev: address selection should only consider devices in L3 domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56C3B56F.4020106@cumulusnetworks.com>
Date:	Tue, 16 Feb 2016 16:49:03 -0700
From:	David Ahern <dsa@...ulusnetworks.com>
To:	David Lamparter <equinox@...c24.net>
Cc:	netdev@...r.kernel.org, david@...nsourcerouting.org
Subject: Re: [net-next] net: l3mdev: address selection should only consider
 devices in L3 domain

On 2/16/16 4:41 PM, David Lamparter wrote:
> ... this won't do enough.  If you look at the 4.3 patch I sent you, I
> was adding a comment:
>
> + /* For VRFs, the VRF device takes the place of the loopback device,
> +    with addresses on it being preferred.  Note in such cases the
> +    loopback device will be among the devices that fail the vrf_ifi
> +    equality check in the loop below.
> +  */
>

Sure, I was focused on fixing the 'ignore devices not in the VRF' but 
certainly for unnumbered use cases you want the VRF loopback address to 
be preferred. Missed that earlier.

Rather than spinning a patch on top of mine, fold this change into your 
and make it 1 patch to achieve the goal.