netdev - Re: [net-next] net: l3mdev: address selection should only consider devices in L3 domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160216.200518.1495764396935534189.davem@davemloft.net>
Date:	Tue, 16 Feb 2016 20:05:18 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	equinox@...c24.net
Cc:	dsa@...ulusnetworks.com, netdev@...r.kernel.org,
	david@...nsourcerouting.org
Subject: Re: [net-next] net: l3mdev: address selection should only consider
 devices in L3 domain

From: David Lamparter <equinox@...c24.net>
Date: Wed, 17 Feb 2016 00:41:15 +0100

> ... this won't do enough.  If you look at the 4.3 patch I sent you, I
> was adding a comment:
> 
> + /* For VRFs, the VRF device takes the place of the loopback device,
> +    with addresses on it being preferred.  Note in such cases the
> +    loopback device will be among the devices that fail the vrf_ifi
> +    equality check in the loop below.
> +  */

I know that some parts of of net/ipv4/devinet.c uses this comment
style, it is not correct for new networking code.  Therefore,
please update your patch to use the proper style:

	/* Like
	 * this.
	 */

Thanks.