netdev - Re: [PATCH net-next V1 04/12] net/mlx5e: Support DCBNL IEEE ETS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALzJLG-A5nrtUcCVXrxfUxggtbZ34x==NySXWbWzOtdGsS19cA@mail.gmail.com>
Date:	Thu, 18 Feb 2016 17:58:12 +0200
From:	Saeed Mahameed <saeedm@....mellanox.co.il>
To:	John Fastabend <john.fastabend@...il.com>
Cc:	Saeed Mahameed <saeedm@...lanox.com>,
	"David S. Miller" <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Tal Alon <talal@...lanox.com>,
	Eran Ben Elisha <eranbe@...lanox.com>,
	Tariq Toukan <tariqt@...lanox.com>,
	Rana Shahout <ranas@...lanox.com>,
	Yevgeny Petrilin <yevgenyp@...lanox.com>,
	Matthew Finlay <matt@...lanox.com>
Subject: Re: [PATCH net-next V1 04/12] net/mlx5e: Support DCBNL IEEE ETS

On Thu, Feb 18, 2016 at 5:30 PM, John Fastabend
<john.fastabend@...il.com> wrote:
>
> Hi Saeed,
>
> I just changed the signature on the setup_tc ndo hook so you will
> need to change this to something like,
>
> static int __mlx5e_setup_tc(struct net_device *dev, u32 handle,
>                             __be16 proto, struct tc_to_netdev *tc)
> {
>         if (handle != TC_H_ROOT || tc->type != TC_SETUP_MQPRIO)
>                 return -EINVAL;
>         return mlx5e_setup_tc(dev, tc->tc)
> }
>
>
> and then use __mlx5e_setup_tc() to populate the ndo op hook. If you
> look at the mlx4 drivers I did this change there already.
>
> Other than that nice to see another dcb supporting driver.
>
> Thanks,
> John
Hi John,

Thanks for pointing that out, will fix this out.

Thanks,
Saeed