netdev - Re: [net PATCH v3 1/1] net_sched fix: reclassification needs to consider ether protocol changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160218.111513.881417469088873961.davem@davemloft.net>
Date:	Thu, 18 Feb 2016 11:15:13 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jhs@...atatu.com
Cc:	netdev@...r.kernel.org, daniel@...earbox.net,
	xiyou.wangcong@...il.com
Subject: Re: [net PATCH v3 1/1] net_sched fix: reclassification needs to
 consider ether protocol changes

From: Jamal Hadi Salim <jhs@...atatu.com>
Date: Thu, 18 Feb 2016 07:38:04 -0500

> From: Jamal Hadi Salim <jhs@...atatu.com>
> 
> actions could change the etherproto in particular with ethernet
> tunnelled data. Typically such actions, after peeling the outer header,
> will ask for the packet to be  reclassified. We then need to restart
> the classification with the new proto header.
> 
> Example setup used to catch this:
> sudo tc qdisc add dev $ETH ingress
> sudo $TC filter add dev $ETH parent ffff: pref 1 protocol 802.1Q \
> u32 match u32 0 0 flowid 1:1 \
> action  vlan pop reclassify
> 
> Fixes: 3b3ae880266d ("net: sched: consolidate tc_classify{,_compat}")
> Signed-off-by: Jamal Hadi Salim <jhs@...atatu.com>

Applied and queued up for -stable, thanks Jamal.