netdev - Re: [patch net-next] bridge: switchdev: Offload VLAN flags to hardware bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160218.111832.1197390152083718401.davem@davemloft.net>
Date:	Thu, 18 Feb 2016 11:18:32 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jiri@...nulli.us
Cc:	netdev@...r.kernel.org, idosch@...lanox.com, eladr@...lanox.com,
	yotamg@...lanox.com, ogerlitz@...lanox.com,
	roopa@...ulusnetworks.com, nikolay@...ulusnetworks.com
Subject: Re: [patch net-next] bridge: switchdev: Offload VLAN flags to
 hardware bridge

From: Jiri Pirko <jiri@...nulli.us>
Date: Thu, 18 Feb 2016 14:01:46 +0100

> From: Ido Schimmel <idosch@...lanox.com>
> 
> When VLANs are created / destroyed on a VLAN filtering bridge (MASTER
> flag set), the configuration is passed down to the hardware. However,
> when only the flags (e.g. PVID) are toggled, the configuration is done
> in the software bridge alone.
> 
> While it is possible to pass these flags to hardware when invoked with
> the SELF flag set, this creates inconsistency with regards to the way
> the VLANs are initially configured.
> 
> Pass the flags down to the hardware even when the VLAN already exists
> and only the flags are toggled.
> 
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Applied, thanks guys.