netdev - Re: [PATCH 2/2] net, thunderx: Use bool in structs where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160218.150631.574392083739567663.davem@davemloft.net>
Date:	Thu, 18 Feb 2016 15:06:31 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	robert.richter@...iumnetworks.com
Cc:	sgoutham@...ium.com, rric@...nel.org, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] net, thunderx: Use bool in structs where possible

From: Robert Richter <robert.richter@...iumnetworks.com>
Date: Thu, 18 Feb 2016 17:42:17 +0100

> On 18.02.16 11:05:14, David Miller wrote:
>> From: Robert Richter <rrichter@...iumnetworks.com>
>> Date: Thu, 18 Feb 2016 13:39:09 +0100
>> 
>> > From: Robert Richter <rrichter@...ium.com>
>> > 
>> > Looks like the :1 notation was accidentally introduced (this still
>> > uses 1 byte per flag). Using bool instead, which is the common use.
>> > 
>> > Signed-off-by: Robert Richter <rrichter@...ium.com>
>> 
>> Such cleanups are not appropriate for 'net'.  Only real bug fixes should
>> be targetted that.
>> 
>> Respin these patches targetting the correct tree(s).
> 
> Do you mean posting the two as "trivial" patches?

No I mean posting #1 targetted at my 'net' GIT tree as a bug fix,
and posting #2 targetted separately at my 'net-next' GIT tree as
a cleanup.

This is how we've been doing things for more than a decade.