netdev - Re: [PATCH] net: bcmgenet: Add MDIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56C6AC81.5020508@gmail.com>
Date:	Thu, 18 Feb 2016 21:47:45 -0800
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Jaedon Shin <jaedon.shin@...il.com>
Cc:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
	Petri Gynther <pgynther@...gle.com>, opendmb@...il.com
Subject: Re: [PATCH] net: bcmgenet: Add MDIO_INTR in GENETv2

Hi Jaedon

Le 15/02/2016 19:12, Jaedon Shin a écrit :
> 
> As you said, the part in bcmgenet_irq_task() is a problem.
> 
> The bcmgenet using internal PHY should use phy_mac_interrupt() cause it has not
> PHY_POLL, and it depends on Ethernet MAC ISR.
> 
> UMAC_IRQ_LINK_EVENT(LINK_UP and LINK_DOWN) was working correctly in GENETv2,
> but (priv->hw_params->flags & GENET_HAS_MDIO_INTR) was blocking to call
> phy_mac_interrupt(). I didn't find a reason through datasheet without MDIO_INTR
> in GENETv2. However, I'm not sure using MDIO_INTR.
> 
> Therefore if MDIO_INTR is not valid in GENETv2, I will send the patch again 
> to remove the first chicken GENET_HAS_MDIO_INTR after your confirm.

MDIO interrupts are wired in GENETv2, so the second part of your patch
is correct, I see now that you have submitted a proper fix for the Link
UP/DOWN event condition, and thank you for doing that. FWIW, all GENET
versions have link UP/DOWN interrupts.
--
Florian