netdev - Re: [PATCH] net: bcmgenet: Fix internal PHY link state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56C6ACD6.60202@gmail.com>
Date:	Thu, 18 Feb 2016 21:49:10 -0800
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Jaedon Shin <jaedon.shin@...il.com>, netdev@...r.kernel.org
Cc:	David Miller <davem@...emloft.net>,
	Petri Gynther <pgynther@...gle.com>, opendmb@...il.com
Subject: Re: [PATCH] net: bcmgenet: Fix internal PHY link state

Le 18/02/2016 20:48, Jaedon Shin a écrit :
> The PHY link state is not chaged in GENETv2 caused by the previous
> commit 49f7a471e4d1 ("net: bcmgenet: Properly configure PHY to ignore
> interrupt") was set to PHY_IGNORE_INTERRUPT in bcmgenet_mii_probe().
> 
> The internal PHY should use phy_mac_interrupt() when not in use
> PHY_POLL. The statement for phy_mac_interrupt() has two conditions. The
> first condition to check GENET_HAS_MDIO_INTR is not related PHY link
> state, so this patch removes it.
> 
> Fixes: 49f7a471e4d1 ("net: bcmgenet: Properly configure PHY to ignore interrupt")
> Signed-off-by: Jaedon Shin <jaedon.shin@...il.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>

Thanks!
-- 
Florian