netdev - Re: [PATCH net] af_unix: Don't use continue to re-execute unix_stream_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160219.235107.1810934052787203460.davem@davemloft.net>
Date:	Fri, 19 Feb 2016 23:51:07 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	rweikusat@...ileactivedefense.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	hannes@...essinduktion.org, joseph.salisbury@...onical.com,
	edumazet@...gle.com
Subject: Re: [PATCH net] af_unix: Don't use continue to re-execute
 unix_stream_read_generic loop

From: Rainer Weikusat <rweikusat@...ileactivedefense.com>
Date: Thu, 18 Feb 2016 12:39:46 +0000

> The unix_stream_read_generic function tries to use a continue statement
> to restart the receive loop after waiting for a message. This may not
> work as intended as the caller might use a recvmsg call to peek at
> control messages without specifying a message buffer. If this was the
> case, the continue will cause the function to return without an error
> and without the credential information if the function had to wait for a
> message while it had returned with the credentials otherwise. Change to
> using goto to restart the loop without checking the condition first in
> this case so that credentials are returned either way.
> 
> Signed-off-by: Rainer Weikusat <rweikusat@...ileactivedefense.com>
> Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

Applied, thanks.