netdev - Re: [PATCH] unix_diag: fix incorrect sign extension in unix_lookup_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160219.235000.1109030635629935367.davem@davemloft.net>
Date:	Fri, 19 Feb 2016 23:50:00 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	xiyou.wangcong@...il.com
Cc:	ldv@...linux.org, xemul@...allels.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] unix_diag: fix incorrect sign extension in
 unix_lookup_by_ino

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Fri, 19 Feb 2016 16:21:14 -0800

> On Thu, Feb 18, 2016 at 5:27 PM, Dmitry V. Levin <ldv@...linux.org> wrote:
>> The value passed by unix_diag_get_exact to unix_lookup_by_ino has type
>> __u32, but unix_lookup_by_ino's argument ino has type int, which is not
>> a problem yet.
>> However, when ino is compared with sock_i_ino return value of type
>> unsigned long, ino is sign extended to signed long, and this results
>> to incorrect comparison on 64-bit architectures for inode numbers
>> greater than INT_MAX.
>>
>> This bug was found by strace test suite.
>>
>> Signed-off-by: Dmitry V. Levin <ldv@...linux.org>
>> Cc: <stable@...r.kernel.org>
> 
> Fixes: 5d3cae8bc39d ("unix_diag: Dumping exact socket core")
> Acked-by: Cong Wang <xiyou.wangcong@...il.com>

Applied and queued up for -stable.