netdev - Re: [PATCH net-next V1 04/12] net/mlx5e: Support DCBNL IEEE ETS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 21 Feb 2016 14:16:04 +0200
From:	Saeed Mahameed <saeedm@....mellanox.co.il>
To:	Or Gerlitz <gerlitz.or@...il.com>
Cc:	Saeed Mahameed <saeedm@...lanox.com>,
	"David S. Miller" <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Tal Alon <talal@...lanox.com>,
	Eran Ben Elisha <eranbe@...lanox.com>,
	Tariq Toukan <tariqt@...lanox.com>,
	Rana Shahout <ranas@...lanox.com>,
	Yevgeny Petrilin <yevgenyp@...lanox.com>,
	Matthew Finlay <matt@...lanox.com>
Subject: Re: [PATCH net-next V1 04/12] net/mlx5e: Support DCBNL IEEE ETS

On Thu, Feb 18, 2016 at 7:02 PM, Or Gerlitz <gerlitz.or@...il.com> wrote:
> On Thu, Feb 18, 2016 at 12:32 PM, Saeed Mahameed <saeedm@...lanox.com> wrote:
>
>> @@ -2164,6 +2233,9 @@ static void mlx5e_build_netdev(struct net_device *netdev)
>>         netdev->watchdog_timeo    = 15 * HZ;
>>
>>         netdev->ethtool_ops       = &mlx5e_ethtool_ops;
>> +#ifdef CONFIG_MLX5_CORE_EN_DCB
>> +       netdev->dcbnl_ops         = &mlx5e_dcbnl_ops;
>> +#endif
>
> I guess we don't want VF drivers to control the uplink port QoS
> arbiter, PFC setup and such, agree -- I gave this comment on V0
> and you somehow missed addressing that, please do for V2.

Agree, sorry I missed your comment on V0, will fix it in V3 along with
John's comment.