netdev - Re: [PATCH V2 net-next 2/3] lan78xx: add ethtool set & get pause functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160222.141014.1517836822587262524.davem@davemloft.net>
Date:	Mon, 22 Feb 2016 14:10:14 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	Woojung.Huh@...rochip.com
Cc:	ben@...adent.org.uk, netdev@...r.kernel.org
Subject: Re: [PATCH V2 net-next 2/3] lan78xx: add ethtool set & get pause
 functions

From: <Woojung.Huh@...rochip.com>
Date: Mon, 22 Feb 2016 18:28:18 +0000

>> This is incorrect; you should always return the manual settings
>> (fc_request_control flags) here.  If autonegotiation is enabled then
>> your get_settings function will return the actual pause flags.
>> 
> What do you mean "return actual pause flags" when autoneg is enabled?
> Pause flags set by (or default) advertise flag?

It means what was negotiated by autonegotiation, and is actually in use.

Otherwise, how can the user find out what was negotiated?