| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1456171519.15241.65.camel@decadent.org.uk>
Date: Mon, 22 Feb 2016 20:05:19 +0000
From: Ben Hutchings <ben@...adent.org.uk>
To: David Miller <davem@...emloft.net>, Woojung.Huh@...rochip.com
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH V2 net-next 2/3] lan78xx: add ethtool set & get pause
functions
On Mon, 2016-02-22 at 14:10 -0500, David Miller wrote:
> From: <Woojung.Huh@...rochip.com>
> Date: Mon, 22 Feb 2016 18:28:18 +0000
>
> >> This is incorrect; you should always return the manual settings
> >> (fc_request_control flags) here. If autonegotiation is enabled then
> >> your get_settings function will return the actual pause flags.
> >>
> > What do you mean "return actual pause flags" when autoneg is enabled?
> > Pause flags set by (or default) advertise flag?
>
> It means what was negotiated by autonegotiation, and is actually in use.
>
> Otherwise, how can the user find out what was negotiated?
Well, actually we don't *directly* report the autonegotiation flow
control mode at present. We report which pause flags were advertised
and what the link partner advertised, from which you can work it out.
Perhaps ethtool (the utility) should explicitly show what the result
is.
Ben.
--
Ben Hutchings
The generation of random numbers is too important to be left to chance.
- Robert Coveyou
Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)
Powered by blists - more mailing lists