netdev - Re: [PATCH 2/3] gianfar_ptp: fix endianness in get_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160222083558.GB2138@netboy>
Date:	Mon, 22 Feb 2016 09:35:59 +0100
From:	Richard Cochran <richardcochran@...il.com>
To:	Yangbo Lu <yangbo.lu@....com>
Cc:	netdev@...r.kernel.org,
	Claudiu Manoil <claudiu.manoil@...escale.com>
Subject: Re: [PATCH 2/3] gianfar_ptp: fix endianness in get_of_u32()

On Mon, Feb 22, 2016 at 02:49:32PM +0800, Yangbo Lu wrote:
> @@ -431,7 +431,7 @@ static int get_of_u32(struct device_node *node, char *str, u32 *val)
>  
>  	if (!prop || plen != sizeof(*prop))
>  		return -1;
> -	*val = *prop;
> +	*val = be32_to_cpu(*prop);
>  	return 0;
>  }

Why not simply replace get_of_u32 with the standard helper function,
of_property_read_u32?

Thanks,
Richard