netdev - Re: [PATCH 3/3] gianfar: fix endianness for hardware timestamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160222084801.GC2138@netboy>
Date:	Mon, 22 Feb 2016 09:48:03 +0100
From:	Richard Cochran <richardcochran@...il.com>
To:	Yangbo Lu <yangbo.lu@....com>
Cc:	netdev@...r.kernel.org,
	Claudiu Manoil <claudiu.manoil@...escale.com>
Subject: Re: [PATCH 3/3] gianfar: fix endianness for hardware timestamp

On Mon, Feb 22, 2016 at 02:49:33PM +0800, Yangbo Lu wrote:
> @@ -2708,6 +2708,7 @@ static void gfar_clean_tx_ring(struct gfar_priv_tx_q *tx_queue)
>  			struct skb_shared_hwtstamps shhwtstamps;
>  			u64 *ns = (u64 *)(((uintptr_t)skb->data + 0x10) &
>  					  ~0x7UL);
> +			*ns = be64_to_cpu(*ns);
>  
>  			memset(&shhwtstamps, 0, sizeof(shhwtstamps));
>  			shhwtstamps.hwtstamp = ns_to_ktime(*ns);

There is no point in modifying the buffer data in place.

Instead, do this:

			memset(&shhwtstamps, 0, sizeof(shhwtstamps));
			shhwtstamps.hwtstamp = ns_to_ktime(be64_to_cpu(*ns));

or this:

			u64 ns, *ptr = (u64 *)(((uintptr_t)skb->data + 0x10) &
					       ~0x7UL);
			ns = be64_to_cpu(*ptr);

			memset(&shhwtstamps, 0, sizeof(shhwtstamps));
			shhwtstamps.hwtstamp = ns_to_ktime(ns);

> @@ -3037,6 +3038,7 @@ static void gfar_process_frame(struct net_device *ndev, struct sk_buff *skb)
>  	if (priv->hwts_rx_en) {
>  		struct skb_shared_hwtstamps *shhwtstamps = skb_hwtstamps(skb);
>  		u64 *ns = (u64 *) skb->data;
> +		*ns = be64_to_cpu(*ns);
>  
>  		memset(shhwtstamps, 0, sizeof(*shhwtstamps));
>  		shhwtstamps->hwtstamp = ns_to_ktime(*ns);

Same here.

Thanks,
Richard