netdev - Re: [net-next 13/15] i40e/i40evf: use logical operators, not bitwise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1456289702.3060.37.camel@intel.com>
Date:	Tue, 23 Feb 2016 20:55:02 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Alexander Duyck <alexander.duyck@...il.com>,
	David Laight <David.Laight@...LAB.COM>
Cc:	David Miller <davem@...emloft.net>,
	Mitch Williams <mitch.a.williams@...el.com>,
	Netdev <netdev@...r.kernel.org>,
	Neil Horman <nhorman@...hat.com>, sassmann@...hat.com,
	John Greene <jogreene@...hat.com>
Subject: Re: [net-next 13/15] i40e/i40evf: use logical operators, not bitwise

On Mon, 2016-02-22 at 08:33 -0800, Alexander Duyck wrote:
> On Wed, Feb 17, 2016 at 7:38 PM, Jeff Kirsher
> <jeffrey.t.kirsher@...el.com> wrote:
> > From: Mitch Williams <mitch.a.williams@...el.com>
> >
> > Mr. Spock would certainly raise an eyebrow to see us using bitwise
> > operators, when we should clearly be relying on logic. Fascinating.
> >
> > Change-ID: Ie338010c016f93e9faa2002c07c90b15134b7477
> > Signed-off-by: Mitch Williams <mitch.a.williams@...el.com>
> > Tested-by: Andrew Bowers <andrewx.bowers@...el.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> 
> NAK
> 
> The bitwise operator lets us at least make a pass through all rings.
> With this new code you stop as soon as one ring has not completed
> cleaning.

I was hoping to hear from Mitch, but since I have not.  I will send out
a revert of this patch in my next i40e/i40evf update in the next day or
so.
Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)