netdev - Re: [PATCH net-next 01/10] bnxt_en: Improve bnxt_vf_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160225.113128.1989544272292631983.davem@davemloft.net>
Date:	Thu, 25 Feb 2016 11:31:28 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	michael.chan@...adcom.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 01/10] bnxt_en: Improve bnxt_vf_update_mac().

From: Michael Chan <michael.chan@...adcom.com>
Date: Thu, 25 Feb 2016 03:19:25 -0500

> From: Jeffrey Huang <huangjw@...adcom.com>
> 
> Allow the VF to setup its own MAC address if the PF has not administratively
> set it for the VF.  If the perm_mac_address returned by firmware is all
> zeros, that means the PF has not set up the MAC address for the VF and
> we should store it.  This will allow the VF to change the MAC address using
> ndo_set_mac_address() when it sees that the stored permanent MAC address
> is all zeros.
> 
> Signed-off-by: Jeffrey Huang <huangjw@...adcom.com>
> Signed-off-by: Michael Chan <michael.chan@...adcom.com>

What triggers that ->ndo_set_mac_address() call in the VF?

You cannot register an ethernet netdev with an invalid ethernet address,
you must use a random one if you don't have a valid one available.