netdev - Re: [PATCH net-next 04/10] bnxt_en: Refactor bnxt_hwrm_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160225.113237.332720242469554990.davem@davemloft.net>
Date:	Thu, 25 Feb 2016 11:32:37 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	michael.chan@...adcom.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 04/10] bnxt_en: Refactor bnxt_hwrm_set_coal().

From: Michael Chan <michael.chan@...adcom.com>
Date: Thu, 25 Feb 2016 03:19:28 -0500

> Add a function to set all the coalescing parameters.  The function can
> be used later to set both rx and tx coalescing parameters.
> 
> Signed-off-by: Michael Chan <mchan@...adcom.com>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 26 +++++++++++++++++---------
>  1 file changed, 17 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index a7103b5..b87b367 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -3521,6 +3521,21 @@ static void bnxt_hwrm_ring_free(struct bnxt *bp, bool close_path)
>  	}
>  }
>  
> +static void bnxt_hwrm_set_coal_params(
> +	struct bnxt *bp, u32 max_bufs, u32 buf_tmrs, u16 flags,
> +	struct hwrm_ring_cmpl_ring_cfg_aggint_params_input *req)

Don't format arguments like this, it's insanely ugly.  You can and
should fit the first few arguments on the line that opens the argument
list.