netdev - Re: [PATCH RFC v2 18/32] dsa: mv88e6xxx: Prepare for turning this into a library module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87io185jd3.fsf@ketchup.mtl.sfl>
Date:	Sun, 28 Feb 2016 21:40:56 -0500
From:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:	Andrew Lunn <andrew@...n.ch>,
	Florian Fainelli <f.fainelli@...il.com>,
	netdev <netdev@...r.kernel.org>
Cc:	Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH RFC v2 18/32] dsa: mv88e6xxx: Prepare for turning this into a library module

Hi Andrew,

Andrew Lunn <andrew@...n.ch> writes:

> Export all the functions so that we can later turn the module into a
> library module.

As I mentioned in the first RFC [1], wouldn't that be preferable to
avoid adding modules and factorize everything into a single one?

The common code would have a single probe function which calls
mv88e6xxx_lookup_name for every model tables until it finds the good
one.

For the rest of the code, a few additional switch family checks should
do the job. What do you think?

[1] https://patchwork.ozlabs.org/patch/560540/

Thanks,

        -v