netdev - Re: [PATCH net 0/3] r8169:issues fix.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160301.152453.1743613743070525198.davem@davemloft.net>
Date:	Tue, 01 Mar 2016 15:24:53 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	hau@...ltek.com
Cc:	netdev@...r.kernel.org, nic_swsd@...ltek.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 0/3] r8169:issues fix.

From: Chunhao Lin <hau@...ltek.com>
Date: Fri, 26 Feb 2016 16:40:43 +0800

> This series of patches fix 3 issues that are listed below.
> 
> Chunhao Lin (3):
>   r8169:fix nic sometimes doesn't work after changing the mac address.
>   r8169:eliminate error message in using ethtool -S when nic is down.
>   r8169: Enable RX_MULTI_EN for RTL_GIGA_MAC_VER_41~48

I don't agree with changes #1 and #2.

If you are going to go to a model where every single configuration
operation is recorded in software and performed at resume time, then
really do it and fix it in the whole driver.  As currently coded you
are leaving lots of known bugs in the driver.

#2 is even a worse situation.  If you are going to handle things this
way you must sync the counters when the suspend happens, so that the
statistics get call receives up to date values.