netdev - Re: [PATCH] net: fec: Add "phy-reset-active-low" property to DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 2 Mar 2016 21:05:40 +0100
From:	Bernhard Walle <bernhard@...lle.de>
To:	Troy Kisky <troy.kisky@...ndarydevices.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] net: fec: Add "phy-reset-active-low" property to DT

Hi,

sorry for my late reply.

* Troy Kisky <troy.kisky@...ndarydevices.com> [2016-03-01 18:16]:
>    invalid and 1 millisecond will be used instead.
> +- phy-reset-active-low : If present then the reset sequence using the GPIO
> +  specified in the "phy-reset-gpios" property is reversed (H=reset state,
> +  L=operation state).
> ____________________________
> 
> 
> Shouldn't this be named phy-reset-active-high, as you are making the reset active high
> H=reset, L= normal operation

Indeed, you're correct.

Should I send a new patch or a patch that corrects my first patch?
Because it already is in linux-next.

Regards,
Bernhard